feat: update pr rules
This commit is contained in:
@@ -43,7 +43,8 @@ After automated checks pass, review the PR against quality guidelines:
|
|||||||
3. **File size** — Are reference docs reasonably sized for context window consumption?
|
3. **File size** — Are reference docs reasonably sized for context window consumption?
|
||||||
4. **API key handling** — If external APIs are used, are credentials read from environment variables?
|
4. **API key handling** — If external APIs are used, are credentials read from environment variables?
|
||||||
5. **Script quality** — Do scripts have shebang, requirements.txt, and error handling?
|
5. **Script quality** — Do scripts have shebang, requirements.txt, and error handling?
|
||||||
6. **README sync** — Are `README.md` and `README_zh.md` updated for new skills?
|
6. **Language** — Are SKILL.md and code written in English?
|
||||||
|
7. **README sync** — Are `README.md` and `README_zh.md` updated for new skills?
|
||||||
|
|
||||||
See [references/quality-guidelines.md](references/quality-guidelines.md) for soft guidelines details.
|
See [references/quality-guidelines.md](references/quality-guidelines.md) for soft guidelines details.
|
||||||
|
|
||||||
|
|||||||
@@ -49,6 +49,11 @@ If the skill includes helper scripts in `scripts/`:
|
|||||||
- A `requirements.txt` should be present listing all dependencies if external libraries are needed.
|
- A `requirements.txt` should be present listing all dependencies if external libraries are needed.
|
||||||
- Errors should produce clear messages, not raw tracebacks
|
- Errors should produce clear messages, not raw tracebacks
|
||||||
|
|
||||||
## 6. README Sync
|
## 6. Language
|
||||||
|
|
||||||
|
- SKILL.md content and code should be written in English
|
||||||
|
- Reference docs are recommended to be in English
|
||||||
|
|
||||||
|
## 7. README Sync
|
||||||
|
|
||||||
When a new skill is added, both `README.md` and `README_zh.md` should be updated with the new skill in the table. Community-submitted skills should set the Source column to `Community`.
|
When a new skill is added, both `README.md` and `README_zh.md` should be updated with the new skill in the table. Community-submitted skills should set the Source column to `Community`.
|
||||||
|
|||||||
Reference in New Issue
Block a user